Update to ed25519 from rsa#1355
Merged
shati-patel merged 5 commits intogithub:mainfrom Nov 23, 2020
ryanlail:patch-1
Merged
Conversation
Update command to add ssh key to ssh agent to ed25519 from rsa
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@Ryan-16 Thanks so much for opening a PR! I'll get this triaged for review ✨ |
janiceilene
added
content
Contributor
|
This should also require this pull request updating the follow-on article. Can be merged to Ryan's patch and therefore added here. |
Update command to copy key named ed25519 from rsa
This comment has been minimized.
This comment has been minimized.
shati-patel
approved these changes
Nov 23, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thank you for the pull request @ryanlail!
Some of your changes had been fixed by an earlier PR, but the remaining suggestions look great too 🎉 I'll get this merged once tests pass ✔️
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update command to add ssh key to ssh agent to ed25519 from rsa
Why:
The docs are inconsistent with rsa and ed25519
What's being changed:
updating a command to make the docs clearer
Check off the following: